Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "relayer", "user gateway" and "relaying gateway" #39

Merged
merged 5 commits into from
Feb 15, 2020
Merged

Conversation

gnarea
Copy link
Member

@gnarea gnarea commented Feb 15, 2020

Fixes #20.

"relayer" -> "courier"

Because "courier" is a good analogy and needs little explanation.

"user gateway" -> "private gateway"

The word "user" in this context was misleading at best and wrong at worst:

  • Gateways for human users will almost always be private anyway. Human users are always behind a NAT so they can never have an Internet-reachable gateway to run a public gateway -- Ignoring the YOLO types who would consider exposing their gateway via DMZ.
  • A machine/bot can also be a user. And such users will often be connected to a public gateway (that is, one with an Internet address -- like relaynet-internet-gateway).

"relaying gateway" -> "public gateway"

For consistency with the change above. Also, "relaying" was superfluous -- All nodes in Relaynet relay stuff.

@gnarea gnarea self-assigned this Feb 15, 2020
@gnarea gnarea marked this pull request as ready for review February 15, 2020 17:49
@gnarea gnarea merged commit f1777dd into master Feb 15, 2020
@gnarea gnarea deleted the renames branch February 15, 2020 17:49
gnarea added a commit to relaycorp/awala-gateway-internet that referenced this pull request Feb 15, 2020
gnarea added a commit to relaycorp/relaynet-core-js that referenced this pull request Feb 15, 2020
gnarea added a commit to relaycorp/relaynet-core-js that referenced this pull request Feb 15, 2020
gnarea added a commit to relaycorp/awala-gateway-internet that referenced this pull request Feb 20, 2020
* Install dependencies

* Use Node 12 in functional tests

* Transpile TS in Docker container instead of host

So we can use Node 12

* Fix syntax error in Circle CI config

* Fix typo

* Fix permissions after transpiling TS in functional tests

* Fix args passed to `chown`

* Implement stub for server

* Implement server

* Remove stub client used for testing

* Refactor

* Rename NATS subject for parcels received via PDC

* Implement deliverCargo() method

* Rename "relayer", "user gateway" and "relaying gateway"

AwalaNetwork/specs#39

* Fix conding convention violation

* Complete service implementation integration

* Upgrade NATS streaming server

* Implement function to publish messages with NATS streaming

* Support streaming arrays

* Prevent NATS publisher from being reused

* Move NATS publisher to new class

* Make NATS Streaming connection async to simplify code

* Introduce method to send single NATS message

* Refactor tests ahead of implementation

* Migrate PoHTTP interface to NATS Streaming

* Upgrade Jest and related deps

* Convert stream-based implementation to iterable-based

* Fix processing of invalid cargoes

* Make NATS streaming publisher yield ids of published msgs

* Integrate NATS Streaming in deliverCargo method

* Remove plain NATS integration

* Integrate NATS Streaming in gRPC service factory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "relaying gateway" to "relay" and "user gateway" to "gateway"
1 participant