New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SwiftUI Settings redux #1179
Merged
Merged
SwiftUI Settings redux #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in so we can use them from other packages
…stom UserDefaults stuff
Also start AwfulModelTypes package for tagged identifier types.
Would be nice to move .css files over, but they're generated from .less files, and pulling that generation into a Swift package build plugin is more effort than it's worth right now.
Slowly figuring out how to bring themes into SwiftUI. The environment key and view modifier seem like a good step. Manually having to set everything is annoying, but let's try it out on a few different views before trying anything drastic. Also split AwfulSettingsUI into its own package to fix a dependency cycle between AwfulSettings and AwfulTheming. AwfulTheming needs to read some Settings values to do its job, but AwfulSettingsUI needs to theme itself. Maybe there's a smarter breakdown here. Or maybe AwfulSettingsUI can pull its weight if we move the other Settings tab screens over.
…er, and add missing imports previously covered up by the bridging header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked up #1152 and ran with it:
internal
access level relevant.