Skip to content

Commit

Permalink
Update CONTRIBUTING.md (#585)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoranAngevaare committed Nov 3, 2021
1 parent 69cc3ba commit 9841303
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ In particular, don't go into code someone else is maintaining to "PEP8-ify" it (
Other style guidelines (docstrings etc.) are yet to be determined.

### Pull requests
When accepting pull requests, prefer merge or squash depending on how the commit history looks.
- If it's dozens of 'oops' and 'test' commits, best to squash.
- If it's a few commits that mostly outline discrete steps of an implementation, it's worth keeping, so best to merge.
When accepting pull requests, preferrably squash as it attributes all the commits to one single pull request. One might consider merging the pull request without squashing if it's a few commits that mostly outline discrete steps of an implementation which seem worth keeping.

0 comments on commit 9841303

Please sign in to comment.