Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated check for overlapping pulses in a channel #119

Closed
JelleAalbers opened this issue Dec 6, 2018 · 1 comment
Closed

Automated check for overlapping pulses in a channel #119

JelleAalbers opened this issue Dec 6, 2018 · 1 comment

Comments

@JelleAalbers
Copy link
Member

JelleAalbers commented Dec 6, 2018

This is a pathology we encountered during the DAQ test that will probably soon be fixed. However, it would be useful to add an automated check for this to ensure this never recurs. This should just be a simple check for the < condition here: https://github.com/AxFoundation/strax/blob/master/strax/processing/pulse_processing.py#L85, but at the moment implementing it is not a good idea because it would prevent all processing during the DAQ test, until this is fixed :-)

JelleAalbers added a commit to JelleAalbers/strax that referenced this issue Dec 7, 2018
@JelleAalbers JelleAalbers reopened this Jan 20, 2019
@JelleAalbers
Copy link
Member Author

Straxen now automatically checks for this in records for new data. Hopefully there won't be any overlaps, but if there is an occasional one in a weird circumstance, we'll likely want to handle it gently rather than refusing to even build raw_records. (For now, we crash in records unless the config has check_raw_record_overlaps=False.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant