Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore underscore for include_tags in run selection #448

Closed
jingqiangye opened this issue May 25, 2021 · 1 comment · Fixed by #445
Closed

Ignore underscore for include_tags in run selection #448

jingqiangye opened this issue May 25, 2021 · 1 comment · Fixed by #445

Comments

@jingqiangye
Copy link

In the run selection, by default, we ignore the underscore for the tags in the database, but not the underscore for include_tags. Should we make it consistent by applying ignore_underscore to both?

def select_runs(self, run_mode=None, run_id=None,
include_tags=None, exclude_tags=None,
available=tuple(),
pattern_type='fnmatch', ignore_underscore=True):

@JoranAngevaare
Copy link
Member

@jingqiangye, indeed yeah we also noticed. This is already addressed in #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants