Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore if pattern also startswith underscore #445

Merged
merged 3 commits into from May 26, 2021

Conversation

JoranAngevaare
Copy link
Member

What is the problem / what does the code in this PR do
@WenzDaniel just noticed this, let's not remove the underscore from the tag if the pattern also has an underscore.

Copy link

@jingqiangye jingqiangye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorana Thanks for the PR! I just tested it and indeed it nicely solves my issue (#448). Happy to approve ;)

@JoranAngevaare JoranAngevaare merged commit c3ce079 into master May 26, 2021
@JoranAngevaare JoranAngevaare deleted the jorana-patch-2 branch May 26, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore underscore for include_tags in run selection
2 participants