ParallelSourcePlugin fixes and test #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could lead to OS-specific build failures, see e.g. https://travis-ci.org/AxFoundation/strax/jobs/435619324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the ParallelSourcePlugin, and should fix issue #97. I think @coderdj originally hit this issue during the Stockholm strax workshop, and @tunnell has been seeing it during the SR1 conversion.
ParallelSourcePlugins (see docs: https://strax.readthedocs.io/en/latest/developer/parallel.html#parallelsourceplugin) inline other plugins, so they have multiple outputs. They need an intermediate mailbox to stage these outputs to. Unfortunately, this mailbox was named after the original plugin, which clashed with the mailbox used for outputting the data the original plugin produced (e.g. raw_records). If that data was needed anywhere else, e.g. as the final target, strange stuff would happen.
I could not get my test to run with multiprocessing activated. Since multiprocessing isn't tested anywhere else, and we know it has other issues anyway (#92), I've left this for later.