New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared memory transfers, parallel loading, avoid concatenates #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... at least for now
Write to _temp first, then rename
The shared memory transfers were giving problems on mac OSX. Since it is anyway an experimental new feature, I made it optional and default off for now. To enable it (and speed up low-level processing), set the context option Finally, I updated travis CI to try Ubuntu Xenial (16) as well as Ubuntu Trusty (14). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces three performance improvements to strax's core:
raw_records
is a ParallelSourcePlugin, while we'll often want to process starting from records./dev/shm
, which will most likely linger until a machine reboot. We will most likely make shared memory an optional behaviour in the future, so we can turn it off during normal analysis-facility use of strax but take advantage of it for (at least online) processing.As a test, I made and saved records and peaks from raw_records for run 001944 in the xenonnt daqtest db. This would be about 10 GB raw from the DAQ (3.3 GB compressed raw_records). The task took 74.4 seconds before these changes, and now takes 18 seconds. Note:
/data/eventbuilder-sharded
, and writing to/home/xedaq
. Adding more workers seems to give no benefit and actually slightly hurts performance.Finally, two minor changes: