Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes strax crash if an exception occurs while saving data. Previously such exceptions could only be recovered from the metadata of the data type whose saver crashed, since the strax processing command itself just succeeded.
got_exception
of the saver. At the end of processing, we check if any of the savers have this attribute set, and if so, throw the original exception. This would have been sufficient on its own, but it's nicer to report the error and stop processing as soon as the first exception occurs, rather than at the very end.This also adds a test to ensure this behaviour. For ParallelSourcePlugin-inlined savers, this exception handling likely does not work and will require more complicated logic.