Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Area per channel in PE #187

Merged
merged 5 commits into from Jun 5, 2019
Merged

Area per channel in PE #187

merged 5 commits into from Jun 5, 2019

Conversation

JelleAalbers
Copy link
Member

@JelleAalbers JelleAalbers commented Jun 5, 2019 •
edited

  • Change the area_per_channel field of peaks to be in PE, to ensure fewer plugins need to know about the PMT gains.
  • Replace min_hits with min_channels as an option to find_peaks. When set to 2 or higher numbers, this will help cuts down the amount of peaks.
  • Some misc reformatting / recommenting

@JelleAalbers JelleAalbers mentioned this pull request Jun 5, 2019
Merged
@JelleAalbers JelleAalbers merged commit 8d2879b into AxFoundation:master Jun 5, 2019
@JelleAalbers JelleAalbers deleted the pe_integration branch June 5, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JelleAalbers