Cleanup tests, make helpers accessible #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleAalbers
force-pushed
the
available_helpers
branch
from
3f39915
to
cd0378b
Compare
|
The coverage drop is due to the numba-jitted functions being missed in the coverage computation. I disabled jitting in one of the matrix builds and am now submitting coverage only for that, but this does not seem to work either (at least not yet). I also added a python 3.8 build, which is failing at the moment due to some llvm build issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up strax' test helpers file, which contains mainly hypothesis strategies for making random records and peaks for testing data processing routines.
There are now no side effects from importing it -- in particular, we no longer mock numba for performance during tests. This makes the tests take slightly longer, but only if the compilation cache is not present (e.g. on Travis or after changes). Since we use numba in production we should clearly also test with it. Also, since numba is considering using strax as an integration test (numba/numba-integration-testing#29) I'm sure they would appreciate if we don't replace
sys.modules['numba']with a MagicMock...The test helpers file is made accessible as strax.testutils, since some of the functions defined in it could be useful in writing tests for straxen.