Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export downsample #224

Merged
merged 2 commits into from Dec 24, 2019
Merged

Conversation

JosephJHowlett
Copy link
Contributor

Implementing gapsize clustering with two steps will require downsampling, upsampling, and downsampling again, since the sum_waveform will be constructed and saved for the "peaklets" and the "peaks". This separates the downsampling step as its own function for repeated/external use.

Copy link
Member

@JelleAalbers JelleAalbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Joey!

I rebased onto master and added a docstring. We don't need to return the peak; it is modified in-place.

@JelleAalbers JelleAalbers merged commit 07a7d9c into AxFoundation:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants