Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
divide_outputs
doesn't account for lazy mode, so a multi-output plugin could still run away and fetch as much as it likes (potentially blowing up since in lazy mode, the max_messages limits are removed)These together reduce strax's memory usage in single-core mode by about 15-20%, on top of the similar reduction from #241. Lazy mode now uses about ~30% less memory than non-lazy mode.
The only downside of lazy mode, as noted in #241, is that processing slows down significantly (up to 50% or so) when using single-core lazy mode on a multi-core job/machine. The lazy processing topology assumes you cannot do things in parallel, so when you actually can, it is less efficient.
The multicore processing performance and memory use seem unaffected, although the last two changes listed above do affect multicore processing.