Make exception work for incomplete matadata too #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a great feature of strax that is needed if one e.g. wants to load only a small part of the data. The exception is also gread in case the RunMetaData is not available. However in case of incomplete RunMetaData the error is not a strax.RunMetadataNotAvailable but a KeyError since 'start' is not in the RunMetaData. Hence I'd propose to also accept the KeyError as an exception. I've tested in on eb0 for run 7157 and 7158 while loading raw_records with incomplete RunMetaData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great feature of strax that is needed if one e.g. wants to load only a small part of the data. The exception is also gread in case the RunMetaData is not available.
However in case of incomplete RunMetaData the error is not a
strax.RunMetadataNotAvailablebut aKeyErrorsince'start'is not in the RunMetaData. Hence I'd propose to also accept theKeyErroras an exception.I've tested in on eb0 for run 7157 and 7158 while loading raw_records with incomplete RunMetaData:
rr = st.get_array('007158', targets = ['raw_records'], seconds_range = (0,5))