Simplify length computations / protect from wraparounds #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For late records in pulses longer than 32767 samples (327.67 us at 10 ns, 65.5 us at 2ns resolution), the computation
will result in an integer wraparound to negative values, since the record_i field is a 16 bit integer.
For the situations I tested, it seems this does NOT happen in numba compiled functions, only in pure numpy/python. So most of strax is safe. In any case, such long pulses should be pretty rare.
Nonetheless, I went through the code and removed places where we rely on this computation. There were several places where we did
min(samples_per_record, pulse_length - record_i * record_length)
, but this is identically equal tolength
.I also removed an unused and non-working data reduction function (
replace_with_spike
).