fix flip boolean bug in pulse_processing #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An address to this issue: #265
Replaced (-1*flip) with np.where(flip, -1, 1) to fix flip=False bug in records flipping.
using np.where with flip as boolean, will return -1 if flip=True, else returns 1.
Previously boolean meant if flip=False d['data'] will go to 0.
Also I believe that calculating
strax/strax/processing/pulse_processing.py
Line 40 in 8e94cd9
in baseline computation is unnecessary.