Added default check to register

[WenzDaniel]

Checking if defaults are set consistently when registering a new plugin.

[JoranAngevaare]

Hi Daniel, you beat me. I added:

if hasattr(plugin_class, 'takes_config'):
    for p in self._plugin_class_registry.values():
        for k ,v in p.takes_config.items():                
            if (k in plugin_class.takes_config and
                v.get_default('0') != plugin_class.takes_config[k].get_default('0')):
                raise ValueError(f'The value for option "{k}" for "{plugin_class.__name__}" is different from "{p.__name__}"')    

Some ideas:

• Why would you expect to see plugins multiple times? Even if you would, you make a new list each time you call register so I'm not sure if it'd help.
• I haven't ran into strax.InvalidConfiguration, could it be because I used the k in plugin_class.takes_config?
• I think '0' is a safe default?
• May I suggest for provides, plugin in self._plugin_class_registry.items(): ->for plugin in self._plugin_class_registry.values(): as you are not really using provides.

Other than that it looks good, I think we had a similar idea!

I'll add my comments as a review as good practice.

[JoranAngevaare]

Hereby the ideas expressed in the comment above.

[JoranAngevaare]

By the way I've checked your implementation* and it works like a charm!

*See (at bottom of):
home/angevaare/software/straxferno/4.Contexts_run_selection_and_configuration.ipynb

ValueError: Two plugins have a different default value for the same option. The option "trigger_min_area" in "Events" takes as a default "100" while in "DummyClass" the default value is set to "110". Please change one of the defaults.

[WenzDaniel]

Thanks for your comments. As discussed, I added all needed changes.

[JoranAngevaare]

Great! I think you only missed this one:

for plugin in self._plugin_class_registry.values():

[WenzDaniel]

Great! I think you only missed this one:

for plugin in self._plugin_class_registry.values():

Super strange, I changed .items() into values(), but forgot to remove the provides field. Sometimes I doubt my mental health... :D
Good catch thanks.

[JelleAalbers]

Thanks Daniel and Joran!