Scada interface #318
Scada interface #318
Conversation
…into scada_interface
Reset mongo registry for chunk_i == 0 and format comments
There was a problem hiding this comment.
Seems clean and straigtforward!
sorry for 49c0674 it was just a super minor change and some reformating
| (seconds_range is None) + | ||
| (time_within is None) + | ||
| (full_range is None)) | ||
| if selection < 2: |
There was a problem hiding this comment.
@WenzDaniel , could you make full_range a bool and update the Runtime error?
As in :
full_range=False # as kwarg
full_range==False # in selection comparison
and
" time_range, seconds_range, time_within or full_range" # in the Runtime error
There was a problem hiding this comment.
I think a bool is cleaner for an option but it's not too relevant
There was a problem hiding this comment.
I corrected the raise message. About the other thing, first I thought so too. But I think Jelle did this intentionally to allow arrays as input. Otherwise things like
if np.array([start, stop]) :
would give an ambiguity error and one would have to change it in something like:
if np.any(selection) :
…into scada_interface
What is the problem / what does the code in this PR do
In this PR we make some changes to the time range querying via strax.
Can you briefly describe how it works?
I slightly modified estimate_run_start such that it returns the run endtime as well.
Further to_absolute_time_range was modified such that it returns the run endtime in case no time range is selected.
Can you give a minimal working example (or illustrate with a figure)?
At the end of this notebook briefly show the changes.