Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update corrections.py to return sorted dataFrame by read() #340

Merged
merged 2 commits into from Oct 30, 2020

Conversation

ahiguera-mx
Copy link
Contributor

What is the problem / what does the code in this PR do
Need to return sorted dataFrame by index when using function read()
Can you briefly describe how it works?
here is an example of using read() and why is important to return sorted data to avoid confusions
https://github.com/ahiguera-mx/xenon/blob/master/plot_gains.ipynb
Can you give a minimal working example (or illustrate with a figure)?
here is an example of using read() and why is important to return sorted data to avoid confusions
https://github.com/ahiguera-mx/xenon/blob/master/plot_gains.ipynb
Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@JoranAngevaare
Copy link
Member

Looks good, thanks also for the test!

@JoranAngevaare JoranAngevaare merged commit 6852ea2 into master Oct 30, 2020
@JoranAngevaare JoranAngevaare deleted the ahiguera-mx-patch-1 branch October 30, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants