fix key error for non rr multiprocess #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenzDaniel
approved these changes
Jan 5, 2021
| if d in sp.provides: | ||
| log.debug(f'{sp} provides {d}') | ||
| p.dtype[d] = sp.dtype_for(d) | ||
| break |
There was a problem hiding this comment.
Have you checked what happens if you cannot find d in sp.provides.values()? Is the traceback already enough or shall we just add a small raise condition after the for-loop?
There was a problem hiding this comment.
If that happens, there is some deeper bug in strax because it asks you to produce a datatype that is not provided by any of the multi-process plugins, that is troublesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
See issue #372 for the problem.
Can you briefly describe how it works?
When we create a
ParallelSourcePlugin, there is some error in finding thedtypefor a requested data type. This yields the error as in #372.Usually this is not much of a problem but if we already have raw_records registered, this becomes a mess. I now just iterate over the known plugins to the
ParallelSourcePluginto find the right dtype. Given that we have been running like this for a long time illustrates that there are probably few people actually using strax to it's max performance and few will notice.Can you give a minimal working example (or illustrate with a figure)?
I'll upload a
multiprocess problem.ipynbto the StraxTests on the analysiscode repo.Tests?
Nah don't think such a think is likely to occur again any time soon.