Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Address #229
Can you briefly describe how it works?
Rather than figuring out e.g. numpy dependencies and compatibility in the requirements for strax, leave that to the base-environment (unless something is truly incompatible). Parse the requirements as set there (are tested against strax and straxen) such that we don't have to do it here.
The way we set it up now is cyclically unlogical, causing failures like: XENONnT/base_environment#444
This approach has been working perfectly for straxen:
XENONnT/straxen@bde58e9