Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse requirements for testing #383

Merged
merged 2 commits into from Jan 20, 2021

Conversation

JoranAngevaare
Copy link
Member

What is the problem / what does the code in this PR do
Address #229

Can you briefly describe how it works?
Rather than figuring out e.g. numpy dependencies and compatibility in the requirements for strax, leave that to the base-environment (unless something is truly incompatible). Parse the requirements as set there (are tested against strax and straxen) such that we don't have to do it here.

The way we set it up now is cyclically unlogical, causing failures like: XENONnT/base_environment#444

This approach has been working perfectly for straxen:
XENONnT/straxen@bde58e9

@WenzDaniel
Copy link
Collaborator

I do not remember were the pandas and numpy requirements imposed by straxen?

@JoranAngevaare
Copy link
Member Author

Nope, numpy was imposed since pip installed a pre-release of 1.20 which is incompatible with py36. Pandas was imposed in a similar way. There was a whole train of commits related to this in strax and straxen, which fueled my frustration: XENONnT/base_environment#404

This PR should put an end to this tuning of (in)compatibilities and leave such decisions to the user or dedicated software: https://github.com/XENONnT/base_environment/

We should here (in strax' requirements) just concern ourself with figuring out which version is compatible with the code rather than with what package and what not each dependency is compatible with.

@WenzDaniel
Copy link
Collaborator

We should here (in strax' requirements) just concern ourself with figuring out which version is compatible with the code rather than with what package and what not each dependency is compatible with.

Agreed, this is why I was asking.

@JoranAngevaare JoranAngevaare merged commit cf4f48c into AxFoundation:master Jan 20, 2021
@JoranAngevaare JoranAngevaare deleted the relax_requirements branch January 20, 2021 19:17
@JoranAngevaare JoranAngevaare linked an issue Jan 20, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministic/pinned test environment
2 participants