New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nveto changes #384
Nveto changes #384
Conversation
Hi Daniel, thanks for the note and the explanation. Like you also mention, it's nice to have somewhat consistent usage among NV & TPC, the downside for noisy wfs is granted but wouldn't you want to cut those anyway. I'm asking because I'd hate if in the end no one understand why there are two different widths in the hitlets. Sorry for also asking it, but we should also really add tests for this. It's super easy to make a little mistake in abstract code. |
Why should not we allow different parameters for a different type of signal/detector? I do not really understand this argument. In the end we have to see which parameter gives the best results/discrimination power and based on what I have seen so far the area deciles did not perform so well on our SPE signals.
Valid point, but I simply had not any time yet to add those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel, thanks, it's very tarse material to review. I would argue it cannot do without tests but at this stage I'm not finding any obvious mistakes.
Sorry, this was not what I was trying to say. Was just wondering about the noisiness you describe in your note etc. I think it's really nice if we can have multiple algorithms in strax! |
…nto nveto_changes
Hej, as requested I added more tests to the function which indeed also captured some nasty bugs. Further, I extended the documentation of the algorithm in https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:wenz:comissioning:nveto:hitlet_width#explanation_of_the_algorithm as well as in the code itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel!
What is the problem / what does the code in this PR do
In this PR we make some optimizations to the hitlet data_type class.
This PR goes together with: XENONnT/straxen#319