Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer start/stop from any dtype #405

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Infer start/stop from any dtype #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e02e0b4
Infer start/stop from lower dtypes
JoranAngevaare Mar 8, 2021
fc5054a
remove userwarning
JoranAngevaare Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 14 additions & 7 deletions strax/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,8 +777,9 @@ def concat_loader(*args, **kwargs):
def estimate_run_start_and_end(self, run_id, targets=None):
"""Return run start and end time in ns since epoch.

This fetches from run metadata, and if this fails, it
estimates it using data metadata from targets.
This fetches from run metadata, and if this fails, it estimates
it using data metadata from the targets or the underlying
data-types (if it is stored).
"""
try:
res = []
Expand All @@ -790,12 +791,19 @@ def estimate_run_start_and_end(self, run_id, targets=None):
t = int(t.timestamp()) * int(1e9)
res.append(t)
return res
except (strax.RunMetadataNotAvailable, KeyError):
except (strax.RunMetadataNotAvailable, KeyError) as e:
self.log.debug(f'Could not infer start/stop due to type {type(e)} {e}')
pass
# Get an approx start from the data itself,
# then floor it to seconds for consistency
if targets:
for t in strax.to_str_tuple(targets):
self.log.debug('Infer start/stop from targets')
for t in self._get_plugins(strax.to_str_tuple(targets),
run_id,
).keys():
if not self.is_stored(run_id, t):
continue
self.log.debug(f'Try inferring start/stop from {t}')
try:
t0 = self.get_meta(run_id, t)['chunks'][0]['start']
t0 = (int(t0) // int(1e9)) * int(1e9)
Expand All @@ -805,10 +813,9 @@ def estimate_run_start_and_end(self, run_id, targets=None):
return t0, t1
except strax.DataNotAvailable:
pass
warnings.warn(
self.log.warning(
"Could not estimate run start and end time from "
"run metadata: assuming it is 0 and inf",
UserWarning)
"run metadata: assuming it is 0 and inf")
return 0, float('inf')

def to_absolute_time_range(self, run_id, targets=None, time_range=None,
Expand Down