Patch concat hits #411
Merged
Patch concat hits #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenzDaniel
commented
Mar 29, 2021
Comment on lines
+256
to
+261
| # Step 3.: Add np.nan in data but outside of length: | ||
| for h in hitlets: | ||
| if h['length'] < len(h['data']): | ||
| h['data'][-1] = np.nan | ||
| # It is enough to test this for a single hitlet: | ||
| break |
There was a problem hiding this comment.
This test catches the highest_density_region bug
|
We are doing to many tests :D The Travis error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Fixes two bugs which can cause a division by zero bug in hitlet_properties.
Added and refactored hitlet tests. I was not able to find a suitable test for the
yield offsetbug any suggestions are welcome.