update apply function to data & test #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
added
Testing
WenzDaniel
approved these changes
Apr 12, 2021
Co-authored-by: Daniel Wenz <43881800+WenzDaniel@users.noreply.github.com>
Co-authored-by: Daniel Wenz <43881800+WenzDaniel@users.noreply.github.com>
Co-authored-by: Daniel Wenz <43881800+WenzDaniel@users.noreply.github.com>
|
@WenzDaniel , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Move the
apply_data_functionlogic fromst.get_arraytost.get_iterto avoid any malicious/accidental usage ofst.get_iterthereby bypassingapply_data_function.Additionally, we fix an issue we had for a while in straxen that this option was incompatible with selection strings:
https://github.com/XENONnT/straxen/blob/5c945e141bee0d5fa976a6e1a78516a0a172305a/straxen/common.py#L491-L493
Therefore, move the application of this function prior to the application of a selection string.
Can you briefly describe how it works?
apply_data_function is applied just prior to returning the data to the user.
Can you give a minimal working example (or illustrate with a figure)?
See the tests as simple examples of use cases.