Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor concat and get data #430

Merged
merged 20 commits into from
Apr 30, 2021
Merged

Refactor concat and get data #430

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6f0bb19
Removed record_i parameter. Reads like well written prose.
WenzDaniel Apr 25, 2021
50cc27c
Added Tianyus suggestion for get_hitlet_data
WenzDaniel Apr 26, 2021
fd61530
Removed record_i field from hitlet_with_data dtype
WenzDaniel Apr 26, 2021
f874612
Refactored test_get_hitlet_data
WenzDaniel Apr 26, 2021
742c988
Removed record_i field from refresh_hit_to_hitlets
WenzDaniel Apr 26, 2021
d816ce7
Added channel offset.
WenzDaniel Apr 26, 2021
ed4e605
Fixed is_first_record
WenzDaniel Apr 26, 2021
724b571
Removed channel offset from function.
WenzDaniel Apr 27, 2021
bae4384
Added check and test for wrong to_pe shape
WenzDaniel Apr 27, 2021
55ff8b6
Updated hitlet splitting added test for outer splitting function
WenzDaniel Apr 27, 2021
6ee1521
Make HDR robust against negative data
WenzDaniel Apr 28, 2021
e3af20b
Added same for FWHM
WenzDaniel Apr 28, 2021
3eea6ab
Return values
WenzDaniel Apr 29, 2021
0acb641
Update strax/processing/hitlets.py
WenzDaniel Apr 29, 2021
3437297
Made dtype more explicit.
WenzDaniel Apr 30, 2021
87775d8
Merge branch 'refactor_concat_and_get_data' of https://github.com/Wen…
WenzDaniel Apr 30, 2021
ba7315a
Documentation and commenting
WenzDaniel Apr 30, 2021
6eaa981
Updated test
WenzDaniel Apr 30, 2021
c94763f
fiX
WenzDaniel Apr 30, 2021
272927f
Added min_data_field kwargs
WenzDaniel Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions strax/dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,6 @@ def hitlet_with_data_dtype(n_samples):
n_samples = max(n_samples, 2)
additional_fields = [(('Hitlet data in PE/sample with ZLE (only the first length samples are filled)', 'data'),
np.float32, n_samples),
(('Fragment number in the pulse',
WenzDaniel marked this conversation as resolved.
Show resolved Hide resolved
'record_i'), np.int32),
]

return dtype + additional_fields
WenzDaniel marked this conversation as resolved.
Show resolved Hide resolved
Expand Down