Temporary patch div/zero in hitlets #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks we should also add it in line 367 I cannot use "make a suggestions". |
|
@WenzDaniel , no if you return you don't hit that line right? |
|
Yes, but you recompute m in line 367 and hence you can potentially hit the same issue in line 368 again (if you have not encountered the issue already before). As I do not know yet why out of the sudden we run into this issue I prefer to do it on both. |
|
Right, good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
We are seeing some runs (020330) where nveto is failing because of division by zero errors caused here.
We need to figure out where this happens, but that needs some deeper investigation.