Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change growing result offset dtype to int64 #481

Merged
merged 1 commit into from Jul 8, 2021

Conversation

WenzDaniel
Copy link
Collaborator

What is the problem / what does the code in this PR do
Changes default dtype for offset in growing result to np.int64 removes the following warning from tests:

../strax/strax/utils.py:60
  /home/dwenz/mymodules/strax/strax/utils.py:60: DeprecationWarning: `np.int` is a deprecated alias for the builtin `int`. To silence this warning, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    def growing_result(dtype=np.int, chunk_size=10000):

Copy link
Member

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel!

@JoranAngevaare JoranAngevaare merged commit ba3eb8e into master Jul 8, 2021
@JoranAngevaare JoranAngevaare deleted the remove_growing_result_warning branch July 8, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants