Reduce codefactor #487
Merged
Reduce codefactor #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
commented
Jul 14, 2021
| @@ -353,7 +353,6 @@ def get_fwxm(hitlet, fraction=0.5): | |||
| lbi = (index_maximum - 1) - lbi # start sample minus samples we went to the left | |||
| m = data[lbi + 1] - lbs # divided by 1 sample | |||
| if m == 0: | |||
| # TODO No idea how this happened, we need to fix this | |||
|
Code changes on purpose or some mixed up branches? If it is the former I have a closer look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
I'm getting very annoyed by codefactor lately, it's complaining about all kinds of places one has not even touched. Let's start with giving it less gunpowder and work from there.
Can you briefly describe how it works?
Remove todos and disable checks where they are just wrong.