Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added export #508

Merged
merged 3 commits into from Aug 6, 2021
Merged

Added export #508

merged 3 commits into from Aug 6, 2021

Conversation

WenzDaniel
Copy link
Collaborator

No description provided.

@WenzDaniel WenzDaniel mentioned this pull request Aug 5, 2021
Merged
JoranAngevaare
JoranAngevaare approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JoranAngevaare
Copy link
Member

JoranAngevaare commented Aug 5, 2021 •
edited

Would it have been worth writing a small test for #506?

@WenzDaniel
Copy link
Collaborator Author

WenzDaniel commented Aug 5, 2021 •
edited

Yes, I agree, I only thought that we would like to merge this week such that we can reprocess. But, since you need more time for the other PR I can add it in the meantime.

JoranAngevaare
JoranAngevaare approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel!

tests/test_peak_merging.py
peak['length'] = peak_length
peak['dt'] = 1

to_pe = np.ones(10000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to_pe = np.ones(10000)
to_pe = np.ones(np.max(hits['channel']))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this before :D That is why the previous version was failing. In case hits are empty np.max has no identity. Hence I put 10k to avoid some more complicated if else thingy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha okay, I see

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure by the way? I see that there was a typo in hits that was the issue. But okay, it's really not much of an issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I corrected the typo first and hit then the other issue.

@WenzDaniel WenzDaniel merged commit 48411c7 into master Aug 6, 2021
@WenzDaniel WenzDaniel deleted the patch_add_lone_hits branch August 6, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoranAngevaare JoranAngevaare JoranAngevaare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenzDaniel @JoranAngevaare