Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two pbar patches #538

Merged
merged 1 commit into from Oct 4, 2021
Merged

Two pbar patches #538

merged 1 commit into from Oct 4, 2021

Conversation

JoranAngevaare
Copy link
Member

@JoranAngevaare JoranAngevaare commented Oct 2, 2021 •
edited

What is the problem / what does the code in this PR do
Two small patches to the pbar

Can you briefly describe how it works?
Fix:

  • afbeelding

and make this a notebook pbar:

  • afbeelding

@JoranAngevaare JoranAngevaare changed the title Two pbar pathces Two pbar patches Oct 2, 2021
WenzDaniel
WenzDaniel approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I think there was another case I found recently which was not covered. I think it was something like multi-run + usage of selection strings or something. If it still pops up I will revisit it in another PR.

@JoranAngevaare JoranAngevaare merged commit 2d4e15d into AxFoundation:master Oct 4, 2021
@JoranAngevaare JoranAngevaare deleted the pbar_patches branch October 4, 2021 06:18
@JoranAngevaare JoranAngevaare mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenzDaniel WenzDaniel WenzDaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoranAngevaare @WenzDaniel