Failing example for test_conditional_entropy #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WenzDaniel , are you sure it's only the numerical accuracy? I'm a bit surprised that without numba (coveralls) we are passing the test but we are not for the other tests (pytest). |
|
I think so, I mean the difference is less than a per-mill. I think it is doubtful that this tiny difference is caused by a real bug. My guess is that a numba representation of one of the numpy features is implemented in a different way. My guess is the log10 operation, but I will have a closer look. |
|
Shall we keep the examples? I think they can be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Replicate #539 , let's also loosen the test requirement to prevent another fail