Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading SaveWhen.EXPLICIT time range selection #553

Merged
merged 2 commits into from Oct 13, 2021

Conversation

JoranAngevaare
Copy link
Member

@JoranAngevaare JoranAngevaare commented Oct 13, 2021

What is the problem / what does the code in this PR do
Time range selections for SaveWhen.NEVER and SaveWhen.EXPLICIT should be kept on equal footing. Requiring that one makes the data before allowing time ranges is unrealistic.

@JoranAngevaare JoranAngevaare marked this pull request as ready for review October 13, 2021 12:13
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@WenzDaniel WenzDaniel merged commit 039e9c4 into master Oct 13, 2021
@WenzDaniel WenzDaniel deleted the patch_explicit_time_range branch October 13, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants