Changes to savewhen behavoir #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
commented
Oct 14, 2021
| @@ -495,7 +495,7 @@ def do_compute(self, chunk_i=None, **kwargs): | |||
|
|
|||
| # For non-saving plugins, don't be strict, just take whatever | |||
| # endtimes are available and don't check time-consistency | |||
| if int(self.save_when) == strax.SaveWhen.NEVER: | |||
| if int(self.save_when) <= strax.SaveWhen.EXPLICIT: | |||
There was a problem hiding this comment.
WenzDaniel
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
SaveWhen.NEVER->SaveWhen.EXPLICITchanges for the sake of superrunse.g. to fix https://github.com/XENONnT/straxen/pull/691/checks?check_run_id=3886562862#step:8:315
Can you briefly describe how it works?
See #509 for a more detailed discussion