Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for testing python setup.py install #557

Merged
merged 11 commits into from Oct 28, 2021

Conversation

JoranAngevaare
Copy link
Member

@JoranAngevaare JoranAngevaare commented Oct 21, 2021

What is the problem / what does the code in this PR do
Simple script to test that we aren't forgetting any requirements and importing strax works fine after a simple install

This is different from our testing suite, where we use pinned versions of every single requirement that we might need on testing.\

Possible use cases

  • Someone adds a dependency, and does a import dependency, but forgets to add it to the requirements file. We would catch this
  • Keep the requirements.txt file flexible enough to work with loose versions but strict enough to prevent really colliding versions of packages

@JoranAngevaare JoranAngevaare marked this pull request as draft October 21, 2021 07:16
@JoranAngevaare JoranAngevaare marked this pull request as ready for review October 21, 2021 08:24
@JoranAngevaare JoranAngevaare added the Testing Works on testing code label Oct 28, 2021
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoranAngevaare JoranAngevaare merged commit 4dc058e into AxFoundation:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Works on testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants