Add derigister plugins #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Thanks Daniel, looks simple.
We could make it more efficient by first making a list of all provided plugins, then check which plugins have a dependency which is not in that list, and follow their provides and depends to increase the total list of to delete the plugins, then you don't have to do this lengthy while loop.
Not that it matters, probably this is also very fast but it seems a bit more complex than it has to 😉
Co-authored-by: Joran Angevaare <jorana@nikhef.nl>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
In this PR we add a small function which cleans the plugin class registry in case some data types are not provided. This can be handy if for example the user would like to replace the DAQReader with some simulation plugin which does not provide for example an output for the muon and neutron-veto.
Can you briefly describe how it works?
Loops over plugin class registry until all plugin provides are provided by other plugins. Added also a test for it