Fix memory leak plugin caching #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Fix memory leak as described in #559
Can you briefly describe how it works?
In #545 we allowed temp plugins to be cached. This however causes issues as if one is doing this for many runs, you are starting to make a lot of these guys in your registry without cleanup or without re-use.
To fix this, we use the deterministic hash such that the next time, we are asking for the same plugin to load the data. This will actually also loading and computing targets on event-level by all the perks of the caching mechanism.
One thing I'm still very surprised about is the amount of data remnant in the temporary merge only plugins.
Can you give a minimal working example (or illustrate with a figure)?
Please checkout the linked issue