fail for - run_ids

strax/storage/files.py

@@ -94,6 +94,7 @@ def _scan_runs(self, store_fields):
 
     def _find(self, key, write,
               allow_incomplete, fuzzy_for, fuzzy_for_options):
+        self.raise_if_non_compatible_run_id(key.run_id)
         dirname = osp.join(self.path, str(key))
         exists = os.path.exists(dirname)
         bk = self.backend_key(dirname)
@@ -192,6 +193,11 @@ def remove(self, key):
         # (which FileStore should do) is sufficient.
         pass
 
+    @staticmethod
+    def raise_if_non_compatible_run_id(run_id):
+        if '-' in str(run_id):
+            raise ValueError("The filesystem frontend does not understand"
+                             " run_id's with '-', please replace with '_'")
 
 @export
 def dirname_to_prefix(dirname):

strax/storage/mongo.py

@@ -309,7 +309,11 @@ def _close(self):
 
 def backend_key_to_query(backend_key):
     """Convert backend key to queryable dictionary"""
-    n, d, l = backend_key.split('-')
+    split_key = backend_key.split('-')
+    if len(split_key) != 3:
+        raise ValueError(f'backend_key ({backend_key}) has too many "-"s,'
+                         f' don\'t use "-" within run_ids')
+    n, d, l = split_key
     return {'number': int(n), 'data_type': d, 'lineage_hash': l}
 
 

tests/test_storage.py

@@ -0,0 +1,32 @@
+import unittest
+import strax
+from strax.testutils import Records, Peaks
+import os
+import shutil
+import tempfile
+
+
+class TestPerRunDefaults(unittest.TestCase):
+    """Test the saving behavior of the context"""
+    def setUp(self):
+        self.path = os.path.join(tempfile.gettempdir(), 'strax_data')
+        self.st = strax.Context(use_per_run_defaults=True,
+                                register=[Records],)
+        self.target = 'records'
+
+    def tearDown(self):
+        if os.path.exists(self.path):
+            print(f'rm {self.path}')
+            shutil.rmtree(self.path)
+
+    def test_write_data_dir(self):
+        self.st.storage = [strax.DataDirectory(self.path)]
+        run_id = '0'
+        self.st.make(run_id, self.target)
+        assert self.st.is_stored(run_id, self.target)
+
+    def test_complain_run_id(self):
+        self.st.storage = [strax.DataDirectory(self.path)]
+        run_id = 'run-0'
+        with self.assertRaises(ValueError):
+            self.st.make(run_id, self.target)