Infer type from default option #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream changes
merge upstream
merge upstream changes
merge upstream changes
JoranAngevaare
approved these changes
Nov 1, 2021
This was referenced Nov 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #568. Overriding of type parameter by builtins.type is removed and some logic is added to handle numpy types correctly. Explicit type of the
apply_data_functioncontext option is set since it can handle iterables and functions but the default value is a tuple.This should me merged with care since it may result in breaking existing code if users were setting options to values with a different type as the default value. We may want to switch the validation error to a warning in cases where the type was inferred from a default value.