Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #585

Merged
merged 1 commit into from
Nov 3, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ In particular, don't go into code someone else is maintaining to "PEP8-ify" it (
Other style guidelines (docstrings etc.) are yet to be determined.

### Pull requests
When accepting pull requests, prefer merge or squash depending on how the commit history looks.
- If it's dozens of 'oops' and 'test' commits, best to squash.
- If it's a few commits that mostly outline discrete steps of an implementation, it's worth keeping, so best to merge.
When accepting pull requests, preferrably squash as it attributes all the commits to one single pull request. One might consider merging the pull request without squashing if it's a few commits that mostly outline discrete steps of an implementation which seem worth keeping.