Add funcs for getting stored source #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
added
enhancement
WenzDaniel
approved these changes
Nov 18, 2021
strax/context.py
Outdated
Comment on lines
1682
to
1683
| if check_forbidden and target in forbidden: | ||
| return None |
There was a problem hiding this comment.
Maybe be more explicit in this case and raise an error or make a warning. Like you have further down.
jmosbacher
approved these changes
Nov 18, 2021
strax/context.py
Outdated
|
|
||
| stored_sources = set() | ||
| for dep in deps: | ||
| if self.is_stored(run_id, dep): |
There was a problem hiding this comment.
isnt this redundent? shouldnt the recursive call to self.get_source check if its stored or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Sometimes you want to process
event_infobut don't know if you have all the required datatypes that are needed for making that data. Rather than doing a try for except, you might from the start want to know if that data can be computed, and where you need to start processing from.In this PR we add just that.
Can you briefly describe how it works?
Look at the target you want to compute, if it's not stored, check if the dependencies are stored. If finally you reach a plugin that is either not stored or not depending on anything (
raw_records), returnNone, indicating that you cannot make this data.