Fix online monitor bug for only md stored #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
commented
Nov 24, 2021
Comment on lines
-184
to
+194
| query = backend_key_to_query(str(key)) | ||
| if self.db[self.col_name].count_documents(query): | ||
| self.log.debug(f"{key} is in cache.") | ||
| # Should have at least one non-metadata chunk, otherwise there | ||
| # is no data to load | ||
| query = {**backend_key_to_query(str(key)), | ||
| 'provides_meta': False | ||
| } | ||
| if self.collection.count_documents(query): | ||
| self.log.debug(f"{key} is in database.") |
There was a problem hiding this comment.
Alternately the same query would work but we check that count_documents() returns at least 2
There was a problem hiding this comment.
Right, this is true and actually what I did first (when I was trying to isolate the issue). Due to another bug (in my old version of the test) it did not seem to work. I could now change now, but I guess there is not much of a difference now.
Comment on lines
+209
to
+217
| # Now check that both frontends understand there is no data (even when | ||
| # allow_incomplete is set) | ||
| stored_in_st = self.is_stored_in_mongo | ||
| stored_in_incomplete_st = self.stored_in_context(st_incomplete_allowed) | ||
| if stored_in_st or stored_in_incomplete_st: | ||
| raise RuntimeError(f'Only metadata written and should NOT stored in st ' | ||
| f'({stored_in_st}) and st_incomplete (' | ||
| f'{stored_in_incomplete_st}) ' | ||
| f'\n{self.chunk_summary}') |
There was a problem hiding this comment.
This is the check that failed before and is now fixed
JoranAngevaare
commented
Nov 24, 2021
darrylmasson
approved these changes
Nov 26, 2021
strax/storage/mongo.py
Outdated
| @@ -160,7 +160,7 @@ def _clean_first_key_from_registry(self): | |||
| class MongoFrontend(StorageFrontend): | |||
| """MongoDB storage frontend""" | |||
|
|
|||
| def __init__(self, uri, database, col_name=None, *args, **kwargs): | |||
| def __init__(self, uri, database, col_name, *args, **kwargs): | |||
There was a problem hiding this comment.
Sure, let me add some
Comment on lines
-184
to
+194
| query = backend_key_to_query(str(key)) | ||
| if self.db[self.col_name].count_documents(query): | ||
| self.log.debug(f"{key} is in cache.") | ||
| # Should have at least one non-metadata chunk, otherwise there | ||
| # is no data to load | ||
| query = {**backend_key_to_query(str(key)), | ||
| 'provides_meta': False | ||
| } | ||
| if self.collection.count_documents(query): | ||
| self.log.debug(f"{key} is in database.") |
There was a problem hiding this comment.
Alternately the same query would work but we check that count_documents() returns at least 2
|
Since approved I merge to get ready for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Sometimes, we get errors that data cannot be loaded from the MongoFrontend when only the metadata is written. This PR adds a test that was failing (before making the changes in the MongoFrontend).
Can you briefly describe how it works?
Check that a
chunkof data is written rather than only themetadatadocumentCan you give a minimal working example (or illustrate with a figure)?
Please see the tests