Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tight coincidence channel from data_type #614

Merged
merged 5 commits into from
Dec 16, 2021
Merged

Remove tight coincidence channel from data_type #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdb4c38
Remove tight coincidence channel from data_type
WenzDaniel Dec 16, 2021
28de486
Merge branch 'master' into remove_tight_coincidence_channel
WenzDaniel Dec 16, 2021
01866ab
Updated help
WenzDaniel Dec 16, 2021
f1bb73c
Merge branch 'remove_tight_coincidence_channel' of https://github.com…
WenzDaniel Dec 16, 2021
e9929a3
Remove field from splitting
WenzDaniel Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions strax/dtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,8 @@ def peak_dtype(n_channels=100, n_sum_wv_samples=200, n_widths=11):
'saturated_channel'), np.int8, n_channels),
(('Total number of saturated channels',
'n_saturated_channels'), np.int16),
(('Hits within tight range of mean',
(('Channel within tight range of mean',
'tight_coincidence'), np.int16),
(('number of contributing channels within tight range of mean',
'tight_coincidence_channel'), np.int16),
(('Largest gap between hits inside peak [ns]',
'max_gap'), np.int32),
(('Maximum interior goodness of split',
Expand Down
1 change: 0 additions & 1 deletion strax/processing/peak_merging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def merge_peaks(peaks, start_merge_at, end_merge_at,
# Use the tight coincidence of the peak with the highest amplitude
i_max_subpeak = old_peaks['data'].max(axis=1).argmax()
new_p['tight_coincidence'] = old_peaks['tight_coincidence'][i_max_subpeak]
new_p['tight_coincidence_channel'] = old_peaks['tight_coincidence_channel'][i_max_subpeak]

# If the endtime was in the peaks we have to recompute it here
# because otherwise it will stay set to zero due to the buffer
Expand Down