StorageFrontend remoteness attribute and test #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmosbacher
requested changes
Dec 23, 2021
strax/context.py
Outdated
| order in mind. Return the fastest first and try loading from it | ||
| """ | ||
| storage_sfs = self.storage | ||
| storage_sfs.sort(key=lambda x: x.storage_type) |
There was a problem hiding this comment.
Suggested change
| storage_sfs.sort(key=lambda x: x.storage_type) | |
| storage_sfs = sorted(self.storage, key=lambda x: x.storage_type) |
I think you want to keep original list since order is used in copy_to_frontend right? I think the way it is would sort in place the original list no?
strax/context.py
Outdated
| :return: partial object | ||
| """ | ||
| for sb_i, sf in enumerate(self.storage): | ||
| for _, sf in enumerate(self._sorted_storage): |
There was a problem hiding this comment.
Suggested change
| for _, sf in enumerate(self._sorted_storage): | |
| for sf in self._sorted_storage: |
double jeopardy!
There was a problem hiding this comment.
you are absolutely right!
|
Thanks a lot Yossi for the super quick and good review! I've implemented them both 👍 |
JoranAngevaare
changed the title
JoranAngevaare
added
enhancement
jmosbacher
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
The issue is described here:
#566
Can you briefly describe how it works?
Rather than looping over the frontends in the order they were specified by the user, loop over the frontends in order of
StorageTypeCan you give a minimal working example (or illustrate with a figure)?
See some examples in the test