Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test straxen for coverage and backward compatibility #635

Merged
merged 10 commits into from Jan 27, 2022

Conversation

JoranAngevaare
Copy link
Member

@JoranAngevaare JoranAngevaare commented Jan 23, 2022

  • We could increase coverage by running straxen tests on coveralls
  • We could check if changes in a PR would cause issues for running straxen. A fail here would mean we introduce breaking changes. We could either avoid doing that or allow it and fix it on straxens master

In this PR, we don't use any of straxens secrets, so we don't have database access

@JoranAngevaare JoranAngevaare added github_actions Pull requests that update Github_actions code python Pull requests that update Python code Testing Works on testing code labels Jan 23, 2022
@coveralls
Copy link

coveralls commented Jan 23, 2022

Pull Request Test Coverage Report for Build 1736061280

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 88.807%

Totals Coverage Status
Change from base Build 1696976384: 2.9%
Covered Lines: 4570
Relevant Lines: 5146

💛 - Coveralls

@JoranAngevaare JoranAngevaare changed the title test straxen for coverage test straxen for coverage and backward compatibility Jan 23, 2022
@JoranAngevaare JoranAngevaare marked this pull request as ready for review January 24, 2022 07:52
Copy link
Collaborator

@WenzDaniel WenzDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, I like it. Is our testing with coveralls limited? In that case we might only run it under certain conditions. E.g. making a new release.

@JoranAngevaare
Copy link
Member Author

@WenzDaniel , no there is no time constrain. It's only the (possible) annoyance of having to iterate between strax <-> straxen. Could be a good motivation to make sure things are backward compatible at least one release but can also see this being annoying sometimes.

@WenzDaniel
Copy link
Collaborator

In that case I would propose to just give it a try.

@JoranAngevaare JoranAngevaare merged commit 76e0043 into AxFoundation:master Jan 27, 2022
@JoranAngevaare JoranAngevaare deleted the up_coverage branch January 27, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code python Pull requests that update Python code Testing Works on testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants