Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate py3.6 py3.7 #636

Merged
merged 4 commits into from Feb 1, 2022

Conversation

JoranAngevaare
Copy link
Member

Deprecate python 3.6 and python 3.8

Let's make the transition to py>=3.8 such that we can start using things like the walrus operator. See https://docs.python.org/3/whatsnew/3.8.html

The walrus operator

See this example, it's great

if (n := len(a)) > 10:
    print(f"List is too long ({n} elements, expected <= 10)")

@JoranAngevaare JoranAngevaare added dependencies Pull requests that update a dependency file documentation Something should be addressed in the docs github_actions Pull requests that update Github_actions code python Pull requests that update Python code Testing Works on testing code labels Jan 24, 2022
@coveralls
Copy link

coveralls commented Jan 24, 2022

Pull Request Test Coverage Report for Build 1777086487

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.897%

Changes Missing Coverage Covered Lines Changed/Added Lines %
strax/utils.py 1 2 50.0%
Totals Coverage Status
Change from base Build 1777008689: 0.0%
Covered Lines: 4604
Relevant Lines: 5179

💛 - Coveralls

@WenzDaniel
Copy link
Collaborator

Looks good, thanks a lot.

@WenzDaniel
Copy link
Collaborator

Should mention it in Team A first though.

@JoranAngevaare
Copy link
Member Author

yeah it's on the agenda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Something should be addressed in the docs github_actions Pull requests that update Github_actions code python Pull requests that update Python code Testing Works on testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants