Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added lone hit area to area per channel #649

Merged
merged 5 commits into from Mar 9, 2022
Merged

Added lone hit area to area per channel #649

merged 5 commits into from Mar 9, 2022

Conversation

WenzDaniel
Copy link
Collaborator

What is the problem / what does the code in this PR do

Can you briefly describe how it works?
Fix bug in merged S2s

@WenzDaniel WenzDaniel mentioned this pull request Feb 13, 2022
Merged
JoranAngevaare
JoranAngevaare approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good catch.

Is it something we could have spotted with a test?

I'll convert this PR to a draft until we find the right time to merge it because of the implied reprocessing.

@JoranAngevaare JoranAngevaare marked this pull request as draft February 13, 2022 16:36
@coveralls
Copy link

coveralls commented Feb 13, 2022 •
edited

Coverage Status

Coverage increased (+0.001%) to 93.138% when pulling 4515e98 on fix_area_per_channel into c99957e on master.

@WenzDaniel
Copy link
Collaborator Author

Yes, I was thinking about a simple unittest too. However, I think it is not so straight forward as you have to trigger peaklet merging. We could check for some test data if area and sim(area_per_channel) gives the same.

@WenzDaniel WenzDaniel marked this pull request as ready for review March 8, 2022 07:44
@WenzDaniel WenzDaniel merged commit 908f95e into master Mar 9, 2022
@WenzDaniel WenzDaniel deleted the fix_area_per_channel branch March 9, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhut19 zhut19 zhut19 approved these changes

@JoranAngevaare JoranAngevaare JoranAngevaare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WenzDaniel @coveralls @zhut19 @JoranAngevaare