Allow different chunk size #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
commented
Apr 12, 2022
Comment on lines
+1778
to
+1779
| def _check_copy_to_frontend_kwargs(self, run_id, target, target_frontend_id, rechunk, rechunk_to_mb) -> None: | ||
| """Simple kwargs checks for copy_to_frontend""" |
There was a problem hiding this comment.
I must admit I only added this bit because codefactor complained
JoranAngevaare
commented
Apr 12, 2022
Comment on lines
+1849
to
+1851
| if rechunk and md["chunk_target_size_mb"] != rechunk_to_mb: | ||
| self.log.info(f'Changing chunk-size: {md["chunk_target_size_mb"]} -> {rechunk_to_mb}.') | ||
| md.update({'chunk_target_size_mb': rechunk_to_mb}) |
There was a problem hiding this comment.
This is actually the only real change, the rest is cosmetic
jmosbacher
approved these changes
Apr 12, 2022
strax/context.py
Outdated
| def copy_to_frontend(self, | ||
| run_id: str, | ||
| target: str, | ||
| target_frontend_id: ty.Optional[int] = None, | ||
| target_compressor: ty.Optional[str] = None, | ||
| rechunk: bool = False): | ||
| rechunk: False = None, |
There was a problem hiding this comment.
is this a typo or some weird syntax I'm not familiar with? shouldn't it still be a bool type hint?
There was a problem hiding this comment.
definitely a typo. thanks for spotting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow different chunk target size from original