Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change channel when sort_by_time #718

Merged
merged 2 commits into from May 1, 2023
Merged

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

'channel' was changed in

min_channel = x['channel'].min()
channel = x['channel']
if min_channel < 0:
channel -= min_channel
.

So use x['channel'].copy() to make a copy of x['channel'] to avoid this bug.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx added the bug Something isn't working label Apr 29, 2023
@coveralls
Copy link

coveralls commented May 1, 2023

Coverage Status

Coverage: 92.19% (-0.02%) from 92.209% when pulling 5008aba on sort_ch_unchange into 38d24ae on master.

@dachengx dachengx merged commit fa9b4d8 into master May 1, 2023
11 checks passed
@dachengx dachengx deleted the sort_ch_unchange branch May 1, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants