Fix argsort inside numba.jit using kind='mergesort' #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachengx
commented
May 4, 2023
| @@ -306,7 +306,7 @@ def define_run(self: strax.Context, | |||
| if isinstance(data, (pd.DataFrame, np.ndarray)): | |||
| if isinstance(data, np.ndarray): | |||
| data = pd.DataFrame.from_records(data) | |||
|
|
|||
There was a problem hiding this comment.
This is just to remove an unused line.
jmosbacher
approved these changes
May 4, 2023
Nice suggestion. Updated. |
|
Maybe only slightly related to this PR, but would be nice at some point to introduce tests that check that all jit compiled functions produce the same results as their pure python implementations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
As the title described.
This PR is trying to prevent issues like XENONnT/straxen#1175.
Can you briefly describe how it works?
Similar to XENONnT/straxen#1176.
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).